Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportUtils.find_mountains_map() needs to be OS independent #135

Open
MatthewSpofford opened this issue Jan 16, 2022 · 0 comments
Open

ImportUtils.find_mountains_map() needs to be OS independent #135

MatthewSpofford opened this issue Jan 16, 2022 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed priority low This issue is almost unnoticable/unimportant to app function surface importer Issue is regarding surface importing modification.
Milestone

Comments

@MatthewSpofford
Copy link
Collaborator

MatthewSpofford commented Jan 16, 2022

Currently find_mountains_map() is written solely for a Windows OS. This is due to the fact that it uses the winreg module (which can be used to search through the Windows Registery) to find the path of the MountainsMap executable.

So, this function needs to be modified to support other operating systems. This would involve adding some sort of conditional check at the top of the function to determine which OS the tool is currently running (many options on how to do this).

The winreg implementation should then ONLY be run for Windows systems, while some new implementation should be run for MacOS or Linux systems. This new implementation could involve calling the which command to find MountainsMap, or just some other means of finding the MountainsMap executable.

NOTE: MountainsMap may not even be supported by other OSs but Windows, and so you may end up having to just return a MountainsNotFound value (defined in ImportUtils.py) immediately after determining Windows is not being used.

ANOTHER NOTE: I'm not sure what I was thinking with making MountainsNotFound a subtype of str that could then be returned. If you would like to change this to an exception, I think that would still be fair to consider it in the scope of this issue.

@MatthewSpofford MatthewSpofford added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers surface importer Issue is regarding surface importing modification. priority low This issue is almost unnoticable/unimportant to app function labels Jan 16, 2022
@MatthewSpofford MatthewSpofford added this to the v1.0.0 milestone Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed priority low This issue is almost unnoticable/unimportant to app function surface importer Issue is regarding surface importing modification.
Projects
None yet
Development

No branches or pull requests

2 participants