Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge scroll (down+right only) broken #682

Closed
MamiyaOtaru opened this issue May 30, 2024 · 3 comments · Fixed by #683
Closed

edge scroll (down+right only) broken #682

MamiyaOtaru opened this issue May 30, 2024 · 3 comments · Fixed by #683
Assignees

Comments

@MamiyaOtaru
Copy link

MamiyaOtaru commented May 30, 2024

Compiled from git today.

Scrolling with the mouse on the edge of the screen (or window, in windowed mode) works in all directions but down+right. If the cursor graphic changes to the down+right arrow, no scrolling happens.

Linux. Same behavior in Wayland or Xorg

@MamiyaOtaru
Copy link
Author

MamiyaOtaru commented May 30, 2024

I'd blame line 201 in interface.h:
constexpr unsigned int ScrollRightDown = ScrollRight | ScrollLeft; /// scroll right + down

from cc11b81
only been broken for 8 months haha. No one noticed?

edit
confirm changing to
constexpr unsigned int ScrollRightDown = ScrollDown | ScrollRight; /// scroll right + down
allows down/right scroll

@MamiyaOtaru
Copy link
Author

TY! It's great that you are maintaining this project and refreshing the code. I just have to wonder how often you actually play the game. Cause now it scrolls down and left instead of doing nothing at all, but it's still not down and right. Like fire the game up and try it out the fix or something :D

And I gave you the working line in my comment.. should have done a pull request I guess.

Not mad, just bemused

@Jarod42
Copy link
Contributor

Jarod42 commented May 31, 2024

I launch the game, but doesn't play full game most of the time.
But indeed, for this "trivial" fix, I have just compile it :-/
Sorry again for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants