Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimthread maybe incompatible with carpet rule: updateSuppressionCrashFix #79

Open
OptiJava opened this issue Nov 20, 2022 · 0 comments
Open

Comments

@OptiJava
Copy link

updateSuppressionCrashFix rule not work when I add dimthread.
image

I think this problem is caused by two mods modifying the same method:MinecraftServer$tickWorlds

Dimthread source code:
image

Carpet source code:
image
image

Carpet will throw a ThrowableSuppression if there is a StackOverFlowError,and plans to catch it in MinecraftServer$tickWorlds
But dimthread also modifying method MinecraftServer$tickWorlds.

I hope you can solve this problem.Thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant