Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra API functionality for order_status, payment_status & total_order_value #36

Closed
Web10-Joris opened this issue Jun 24, 2024 · 5 comments · Fixed by #39
Closed
Assignees
Labels
enhancement New feature or request

Comments

@Web10-Joris
Copy link

Currently it is not possible to add order_status, payment_status & total_order_value per Parcel right?
Is it possible to built this in?

https://api.sendcloud.dev/docs/sendcloud-public-api/integrations/operations/create-a-integration-shipment

@villermen villermen added the enhancement New feature or request label Jul 8, 2024
@villermen
Copy link
Member

@Web10-Joris The documentation you're referring to is of the integrations API. This client supports the shipping and service points APIs right now. I've checked and there is no option to work with these properties there. It's unlikely I will be available to implement a full new API anytime soon without a PR by someone else.

I'm happy to think with you about an alternative solution for your use case though.

@Web10-Joris
Copy link
Author

@villermen Thanks for your response! I see that the Shipments API also provides order_status & total_order_value as possible input options. https://api.sendcloud.dev/docs/sendcloud-public-api/parcels/operations/create-a-parcel

This is part of the Shipping API right? Then only the payment_status wouldn't be possible, but adding the other two will significantly improve the usage, since it is then possible to set insurances based on the order value and to sync the shipments with the webshop based on their order_status.

@villermen
Copy link
Member

villermen commented Jul 10, 2024

@Web10-Joris For parcel creation it appears only total_order_value+total_order_value_currency are possible because they are linked to delivery (cash on delivery). I'm not seeing the other properties in these calls/the parcel model.

An alternative route could be to send insured_value with the request (currently also not possible) and update it when the order status changes.

@Web10-Joris
Copy link
Author

Will the total_order_value be supported in the future? Would be very helpful for us :)

@villermen villermen self-assigned this Aug 13, 2024
@villermen
Copy link
Member

@Web10-Joris I've added options for total_order_value and total_order_value_currency to the createParcel() method in #39. Note that the client does not perform any validation on these values whatsoever so please make sure to send the value as a decimal string ("99.99"). Improved validation will probably come as part of #38.

@villermen villermen linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants