Incorrect 'permissions changed' output on macOS

[Wilfred]

No description provided.

[Wilfred]

It looks like git tries to pass us the mode:

static void add_external_diff_name(struct repository *r,
				   struct strvec *argv,
				   const char *name,
				   struct diff_filespec *df)
{
	struct diff_tempfile *temp = prepare_temp_file(r, name, df);
	strvec_push(argv, temp->name);
	strvec_push(argv, temp->hex);
	strvec_push(argv, temp->mode);
}

[Wilfred]

This is an issue with our git docs, where we suggest explicitly setting the difftool to difftastic with two arguments.

[Wilfred]

dft = "!f() { GIT_EXTERNAL_DIFF=difft git diff --ext-diff $@; }; f"

is probably a better setting for .gitconfig