-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
64bit values are read using 2 32bit Reads #240
Comments
How so? It just reads two UInt32's then does the endian swap if needed |
Closing as this is intended behaviour. If you think something is wrong please post and comment and I'll reopen. |
put breakpoints on rpm/wpm and you'll see why people complain about their patches taking 10+ minutes to load. The program is a mess and I just commented about one instance that I found of it being slow. |
Yeah, doing two reads to read a 64-bit value isn't great. |
reading the strings 1 byte at a time is probably the worst thing. I would like to point out that most of the time the strings will have a max size and you can just read in the chunk of memory. Here's an example of part my mapheader for reach mcc
|
I'd like to take a look at this at some point. Could you provide a map patch that's slow? |
https://github.com/XboxChaos/Assembly/blob/master/src/Blamite/IO/EndianReader.cs#L152
The text was updated successfully, but these errors were encountered: