Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define appropriate exception subclass for JNI errors #7

Open
aaaaalbert opened this issue Oct 14, 2016 · 2 comments
Open

Define appropriate exception subclass for JNI errors #7

aaaaalbert opened this issue Oct 14, 2016 · 2 comments

Comments

@aaaaalbert
Copy link
Owner

The JNI code/glue should not raise generic Exceptions as done here,

https://github.com/aaaaalbert/sensibility-testbed/blob/use-pure-gradle/app/src/main/jni/jniglue.c#L426

but instead define its own exception subclass. This may happen in C or Python, whatever suits us better.

@lukpueh
Copy link
Collaborator

lukpueh commented Feb 22, 2017

Do you have something particular in mind? Should we provide a generic SensibilityError, or one per *Service.java?

@aaaaalbert
Copy link
Owner Author

@lukpueh, not really. (For comparison, I'm working around the permissions issue in SensibilityTestbed/repy_v2#4 by hiding the Java SecurityException and returning a JSONified null to the caller.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants