Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis webhook verification #87

Open
9999years opened this issue Apr 7, 2018 · 1 comment
Open

Travis webhook verification #87

9999years opened this issue Apr 7, 2018 · 1 comment
Labels

Comments

@9999years
Copy link
Contributor

signature := r.Header.Get("Authorization")

Is the handleSignature function correct? The Travis documentation seems to imply the code should check the Signature header against Travis’ public key.

It seems like the Authorization header is an old method of authenticating Travis requests phased out in November 2016.

@abiosoft abiosoft added the bug label Apr 7, 2018
@abiosoft
Copy link
Owner

abiosoft commented Apr 7, 2018

Oops, thanks for reporting this.
Unfortunately I do not have time to work on this at the moment, it may take a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants