-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide snapshot warning messages if not needed #626
Comments
Do we have an example repository where this is happening? |
@febuiles The "snapshot warning" header field contains the following error: Can the snapshot checks be disabled (or not added to the summary) with a configuration option or some other mechanism? |
@virangdoshi is this happening on a public repo, or do you have a way to reproduce it and share the result? I don't mind considering the idea of disabling snapshots with an option, but would like to see if we can't fix this in the first place. |
@febuiles I am not familiar with snapshots and do not have a way to reproduce this in a public repo. |
I just saw this warning for the first time here nginxinc/nginx-gateway-fabric#1581 if it can help fix this. |
@lucacome that's very useful, thank you! Here's the API output of running DR on that PR:
The snapshots warning matches the error being displayed:
@juxtin The repo ( |
Sorry to hijack the conversation for a second, but I'm still not sure what this dependency snapshot is and why it was only generated on 2023-03-29. Should it be generated more frequently? Is it something that we're missing in the repo? |
@lucacome I'm sorry you ran into this. You can read more about dependency snapshots here. They provide a way to capture build-time information of projects to complement the static analysis Dependency Graph does. Looking at the detector name ( |
@lucacome can you try to re-run the Action? You don't need to merge, but I think the problem has resolved for your repo. The
|
@febuiles the warning is gone, thanks! 🎉 |
Thanks everyone, I've merged a fix for this on the service side, so we shouldn't see any more of these spurious warnings. |
It seems like we still get this error in our workflow: If I query the REST API I do get an empty array as response (which makes sense as no dependencies have changed)
which simply returns Shouldn't this action handle this case gracefully instead? Cause this is quite confusing for our users who see this error on their PRs or as annotation in their checks on their PR. |
Users who are not using dependency snapshots should not be seeing this warning message in their runs:
Triage notes:
I can confirm that I'm getting the correct response header (empty):
@louis-bompart @virangdoshi What
Dependency-Snapshot-Warning
do you receive when running the Action in a problematic PR?The text was updated successfully, but these errors were encountered: