Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bcrypt for password storage #46

Open
MarkJaroski opened this issue Dec 2, 2019 · 5 comments
Open

Bcrypt for password storage #46

MarkJaroski opened this issue Dec 2, 2019 · 5 comments
Labels

Comments

@MarkJaroski
Copy link

It might make sense to shift to the standard password hashing library bcrypt instead of using a custom salt. Cracking bcrypted passwords takes considerably more computing power than SHA1 does, which will slow down any attacker that gets control of the database.

That said, using an upstream IDP might be even better.

@agilare
Copy link
Owner

agilare commented Dec 8, 2019

It's done in the next major version, with guidance of users to update their password.
We could already to that in this version; changing the method of crypt is simple but we'll have also to add a page for users asking them to update their password, and this new password will be saved using bcrypt.

@MarkJaroski
Copy link
Author

Brilliant!

@MarkJaroski
Copy link
Author

I guess we can close this then, but unfortunately the next major version link isn't working for me.

@agilare
Copy link
Owner

agilare commented Jan 3, 2020

But finishing the next version will take time... so if someone can meanwhile improve security of current version exposed...
The repo of the next version is private, I can add you if you're intersted to contribute to it.

@MarkJaroski
Copy link
Author

Yes, please.

@agilare agilare added the high priority label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants