Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - Input Tablature Alignment Error #16

Open
jamesmqle opened this issue Mar 24, 2021 · 0 comments
Open

Bug Report - Input Tablature Alignment Error #16

jamesmqle opened this issue Mar 24, 2021 · 0 comments

Comments

@jamesmqle
Copy link

jamesmqle commented Mar 24, 2021

Error Description:

The converter breaks when the bottom E string is not aligned with the tablature.

Commit #: 8afe0be

Priority:

Medium

Machine/Version:

OS: Windows 10
IDE: IntelliJ version 2020.3.1
Java Version: 15.0.3

Steps to Reproduce:

  1. Run the Application
  2. Load the Following File basstest.txt to the Application or Paste the Following Guitar Tablature Inside the TextBox
G|---------------------------|---------------------------|
D|---------------------------|---------------------------|
A|---------------------------|---------------------------|
   E|-5-3---0-0-0---0-0-0-3-0-5-|-5-3---0-0-0---0-0-0-3-0-5-|
  1. Press the Convert and Save Button
  2. Play the Generated XML file in a musicXML player (eg. MuseScore)

Expected Result:

There are two possible expected results if the above tablature is inputted.

  1. The UI should display a warning error that there is a spacing error that breaks the parser.
  2. The parser should ignore the spacing and convert it normally.

These results depend solely on the developers, however one of these results should be met.

Actual Result

The actual result produces a broken output with only three lines because the converter does not read the 4th line due to it not being aligned with the rest of the tablature.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant