Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dynamic content script #81

Open
airtower-luna opened this issue Nov 6, 2022 · 0 comments
Open

Replace dynamic content script #81

airtower-luna opened this issue Nov 6, 2022 · 0 comments
Milestone

Comments

@airtower-luna
Copy link
Owner

Manifest v3 does not allow dynamically generated content scripts (see the migration guide). Referer Modifier currently uses one to inject the current configuration into content scripts to work around Firefox bug #1601496. Alternatives (loading from storage, messaging the background script) are asynchronous and very likely don't resolve before site scripts get a chance to run and possibly access document.referrer.

What this means is:

  • If the Firefox bug is fixed, the content script can be removed without any loss of function, no matter the manifest version.
  • As long as the bug isn't fixed Referer Modifier will have to stick with Manifest v2 as long as it's supported. If Manifest v3 becomes mandatory without a fix we'll have to accept that page scripts that access document.referrer early will see an unmodified value.
@airtower-luna airtower-luna added the enhancement New feature or request label Nov 6, 2022
@airtower-luna airtower-luna added this to the Manifest v3 milestone Nov 6, 2022
@airtower-luna airtower-luna removed the enhancement New feature or request label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant