Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Modify expander trait to use references #579

Open
prestwich opened this issue Mar 17, 2024 · 2 comments
Open

[Feature] Modify expander trait to use references #579

prestwich opened this issue Mar 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@prestwich
Copy link
Member

Component

sol! macro

Describe the feature you would like

modify SolInputExpander trait to use references instead of owned input, to allow expander chaining and composition

Additional context

No response
@prestwich prestwich added the enhancement New feature or request label Mar 17, 2024
@prestwich prestwich mentioned this issue Mar 17, 2024
Merged
3 tasks
@nkysg nkysg mentioned this issue Apr 3, 2024
Closed
3 tasks
@nkysg
Copy link

nkysg commented Apr 3, 2024

I can try this. Thanks.

@prestwich
Copy link
Member Author

Please hold off for now. I have some ongoing work locally I need to push up that will likely significantly refactor the expander trait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: modify expander trait to use references nkysg/alloy-core
2 participants
@nkysg @prestwich