Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong design: Dependencies separated by "!" #34

Open
ppeterka opened this issue Jun 25, 2017 · 2 comments
Open

Wrong design: Dependencies separated by "!" #34

ppeterka opened this issue Jun 25, 2017 · 2 comments

Comments

@ppeterka
Copy link

Any strings containing multiple paths, or URLs, like the dependencies in AMD:

  • Should be separated by a character that is not valid in the most common file systems
  • Or there should be a way of escaping the separator character(s).

The current spec prevents the module paths from being correctly resolved when any of them contains an exclamation mark.

Problematic part

If Loader Plugins are supported in the AMD implementation, then "!" is used to separate the loader plugin's module id from the plugin's resource id. Since plugin resource ids can be extremely free-form, most characters should be allowed for plugin resource ids.

Suggestions

  • Change the separator to | - which is not valid in a path in all of the file systems I know (many code changes)
  • Have a way to escape ! in a path. even as simply as doubling it up: !!
  • Have a way to enclose full paths, akin to how CSV cells are enclosed
@wangpung12
Copy link

Good

@forjuan
Copy link

forjuan commented Apr 9, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants