Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove S3 paths from notebooks #2

Open
willettk opened this issue Apr 1, 2021 · 2 comments
Open

Remove S3 paths from notebooks #2

willettk opened this issue Apr 1, 2021 · 2 comments
Assignees

Comments

@willettk
Copy link
Contributor

willettk commented Apr 1, 2021

As pointed out by @harsh-parikh, there are several S3 buckets mentioned in the new notebook. S3 buckets shouldn't be included in any commits to this repo (even if access is restricted) unless the bucket is fully public and has been approved. Will have to keep those references in internal documentation.

https://github.com/amzn/credence-to-causal-estimation/blob/credence_new_structure_new_marginal_likelihood/notebooks/example-new-structure.ipynb

@willettk
Copy link
Contributor Author

willettk commented Apr 1, 2021

One possibility would be adding a pre-commit hook to check for S3 paths before allowing commits? Maybe something like git-secrets.

@Louisexu925
Copy link

S3 buckets are removed from all branches with the same notebook. And all branches pass git-secrets scans, after adding a specific pattern for s3 paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants