Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bike stats extracted from the app #42

Open
Strajk opened this issue Feb 26, 2023 · 3 comments
Open

Bike stats extracted from the app #42

Strajk opened this issue Feb 26, 2023 · 3 comments

Comments

@Strajk
Copy link

Strajk commented Feb 26, 2023

Heya, I've managed to extract bike data directly from the app, shall I make PR?
IMO CdA and weight are quite useful, and more precise than just a 1-4 rating shown in the UI.

I would put the parsing logic to update-data.mjs and add TS types, but without actually committing decompiled files.

image

https://docs.google.com/spreadsheets/d/1O2NN5RHH3Q2j4uNjKJTkxqse-Ax2DOf7EcywS5O5-VE/edit#gid=0

@andipaetzold
Copy link
Owner

Hey @Strajk,

great work! A PR would be awesome <3

Would you commit the data itself or would the update-data.mjs download extract the data from the app?

@Strajk
Copy link
Author

Strajk commented Feb 26, 2023

I honestly believe that the data is not sensitive/confidential, but it's reverse-engineered directly from the app that is both compressed and encrypted – so not sure if committing the extracted "raw" xml files is OK. It contains much more info than is shown in the above screenshot.

The extraction & decryption takes a few minutes, and it needs the secret key, so including that in update-data.mjs is also not ideal.

Will come up with sth in the next few days 👍

@andipaetzold
Copy link
Owner

Okay, then maybe a quick documentation about what to do would be better.

@Strajk Strajk mentioned this issue Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants