Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go security release (1.8.7 / 1.9.4) breaks package compilation #268

Closed
rasky opened this issue Feb 8, 2018 · 2 comments
Closed

Go security release (1.8.7 / 1.9.4) breaks package compilation #268

rasky opened this issue Feb 8, 2018 · 2 comments

Comments

@rasky
Copy link

rasky commented Feb 8, 2018 •
edited
Loading

Description of the Go fix that breaks compilation: http://golang.org/issue/23672

LDFLAGS now has a whitelist in place for options it accepts, and it doesn't accept bare filenames. This breaks compilation of ui.

ui/link_linux_386.go

Line 8 in 2dde2a7

// #cgo LDFLAGS: ${SRCDIR}/libui_linux_386.a -lm -ldl

There should probably be a -l added in front of the base library name, and a -L for the directory.
@rasky rasky mentioned this issue Feb 8, 2018
Closed
@andlabs
Copy link
Owner

andlabs commented Feb 8, 2018

I cannot make any fixes currently. What would the equivalent fix on Windows be (note that it needs to link to a .res file as well)?

@andlabs
Copy link
Owner

andlabs commented Feb 21, 2018

Fixed by Go itself. See also golang/go#23749

@andlabs andlabs closed this as completed Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andlabs @rasky