-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't seem to be compilable with LDC 1.37.0 nor 1.38.0 #161
Comments
I've seen other weird issues on compiler upgrades at Weka codebase, with type implicit conversions, so compiler certainly got weirder. @JohanEngelen can confirm these evidences. |
The only recent change to |
So, my predictions is that there's some regression in the compiler. I'll try to prove it. |
@ljmf00-wekaio Do you have test case that I can compile? What argparse version do you use? What OS? PS I checked both 1.37.0 and 1.38.0 in CI build and everything was successfully built. |
@ljmf00-wekaio It appears to be related by wtracer's own implementation of Edit: it is very strange that you cannot ask a SumType what type it holds... So I don't know how to rewrite the code that uses |
@JohanEngelen Thanks for the investigating it! oh, so its not failing on Regarding the `SumType` on Phobos vs our implementation:I had a few discussions on how we should have more freedom on The major reason to have our own copy is also because Maybe this is something you can re-discuss with @pbackus and @atilaneves, but I don't have much energy trying to upstream things to Phobos when they have a strong biased opinion about it. This expands to so many things we have on |
@JohanEngelen I can't see why this is own SumType implementation tho, the path is
|
It could be related to some compiler bug where it mistakes one sumtype for the other, or does something else weird... Perhaps I should just dustmite and see what comes out. |
I'm making a few compiler changes regarding this error, to make it more clear to debug. Will xref here. |
xref: dlang/dmd#16755 |
After the patch:
|
I confirmed this works dlang/phobos#9031 . |
I was wondering why error message has |
This is almost probably a compiler/Phobos regression. CC @pbackus perhaps are you aware of some change on sumtype that affected this? There's no other informational error, so, I can't understand clearly where the issue resides exactly. All I have is this log, and I'm confident its from
argparse
given the type names:The text was updated successfully, but these errors were encountered: