Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning given when using ES2017 #13477

Closed
filipesilva opened this issue Jan 18, 2019 · 1 comment · Fixed by #13643
Closed

No warning given when using ES2017 #13477

filipesilva opened this issue Jan 18, 2019 · 1 comment · Fixed by #13643
Labels
Milestone

Comments

@filipesilva
Copy link
Contributor

🐞 Bug report

Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

No.

Description

Zone.js does not support native async/await (angular/zone.js#1140) as present in ES2017. This means code that happens inside async/await blocks is invisible to zone.js thus not triggering change detection.

Since this is a footgun for developer, Angular CLI should show a warning about this when ES2017 is set as the typescript target.

🔬 Minimal Reproduction

angular/zone.js#1140

🔥 Exception or Error

No error, just no change detection.

🌍 Your Environment


Angular CLI 7.x

Anything else relevant?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant