Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSS] directives & units invisible #1

Closed
VitorLuizC opened this issue Apr 13, 2017 · 4 comments
Closed

[SCSS] directives & units invisible #1

VitorLuizC opened this issue Apr 13, 2017 · 4 comments
Labels

Comments

@VitorLuizC
Copy link

VitorLuizC commented Apr 13, 2017

@directives are just visible after typing brackets.

rem unit and, I think, other units are invisible.

@anoff anoff added the bug label Apr 14, 2017
@anoff
Copy link
Owner

anoff commented Apr 14, 2017

I experienced similar issues with for other languages where incomplete syntax shows unreadable characters (white on white). Haven't bothered so far but I'll try to look into it.

As this is just a port of the theme file without anything vscode specific I wonder if vscode expects specific properties in the theme file that are not set.

You're welcome to tinker around with the theme as well, on your local installation the theme file should be located at ~/.vscode/extensions/anoff.theme-monokai-light-1.0.2

@anoff
Copy link
Owner

anoff commented Apr 14, 2017

Quick fix would be to remove the lines that set invalid

Have to read up on why invalid and invalid.deprecated do not set the background property in vscode as expected.

Edit:
Seems like it's a feature/known bug in vscode.
Probably have to change those invalid settings then to go for a foreground color indicating a problem.
@VitorLuizC Do you have suggestions which color to pick for illegal syntax?

@VitorLuizC
Copy link
Author

VitorLuizC commented Apr 16, 2017

Sorry for the late answer. I think a gray color, like comments, or that default black would be great, It shows the code and let me know its a default text until I finish the directive.

@anoff anoff closed this as completed in feac382 Apr 17, 2017
@anoff
Copy link
Owner

anoff commented Apr 17, 2017

update to v1.0.3 to get black foreground for invalid syntax. I'll monitor the vsc issue in case they decide to bring in background colors and implement that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants