Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: What version to follow for new collection after rename #226

Open
Shilpi-J opened this issue May 4, 2023 · 14 comments
Open

Query: What version to follow for new collection after rename #226

Shilpi-J opened this issue May 4, 2023 · 14 comments

Comments

@Shilpi-J
Copy link

Shilpi-J commented May 4, 2023

Hi Team,
We plan to rename the existing IBM Spectrum Virtualize Ansible collection to IBM Storage Virtualize ansible collection

  • The current release of Spectrum Virtualize Ansible collection is 1.12.0 (released in April'23)
  • I understand through this link that we need to have another release of Spectrum Virtualize collection as 2.0.0 where in we are required to mention the redirects to the new collection.
  • What version number we should put for the new collection - IBM Storage virtualize ansible collection? Should it be 1.0.0 ?

Thanks

@gotmax23
Copy link
Contributor

gotmax23 commented May 4, 2023

What is the current FQCN 1 and what will be the new one? Will the contents be exactly the same?

Footnotes

  1. Fully Qualified Collection Name (i.e. NAMESPACE.NAME)

@Shilpi-J
Copy link
Author

Shilpi-J commented May 5, 2023

@gotmax23
The old collection name is ibm.spectrum_virtualize (https://github.com/ansible-collections/ibm.spectrum_virtualize)
The new collection name is ibm.storage_virtualize (https://github.com/ansible-collections/ibm.storage_virtualize)

It won't be exact copy as we want to change the documentation where in the word "spectrum virtualize" is used. This would be changed to "storage virtualize" at those places.
Also, we plan to release some new additional modules and features in the new collection.

Please guide as accordingly.

@Shilpi-J
Copy link
Author

Shilpi-J commented May 8, 2023

@gotmax23 I hope I answered your question. Do let me know if any other information is also required.

@webknjaz
Copy link
Member

webknjaz commented May 8, 2023

where in we are required to mention the redirects to the new collection.

Note that you need to declare a redirect in a structured way, so that Ansible would them follow to the new collection automatically.

@felixfontein
Copy link
Contributor

Please note that the general process is described in this repo's README: https://github.com/ansible-community/ansible-build-data#renaming-a-collection. Having new modules in the new collection is no problem/plugins, the main thing is that the old modules/plugins are backwards compatible to the ones of the same name in the old collection.

@Shilpi-J
Copy link
Author

Shilpi-J commented May 9, 2023

@felixfontein Thanks for the response. Yes, we had gone through the same link to get hold of renaming requirements.
But since the documentation of all the modules will get changed due to change in name of brand altogether (spectrum being replaced with storage), thats why I asked this question .. what version should we give?
Although, the functionality remains same in both the collections.

Do you think that this below option would be fine?

  • ibm.storage_virtualize ansible collection version 0.1.0 with same changes (no changes at all)
  • and then we plan release version 1.0.0 with changes in documentation plus extra features

@webknjaz
Copy link
Member

webknjaz commented May 9, 2023

@Shilpi-J since it's a new collection that's already starting off being stable, I'd go for v1.0.0.

@Shilpi-J
Copy link
Author

Shilpi-J commented May 9, 2023

Thanks @webknjaz
Do you think that below option can also be used?
Option 1:

  • ibm.storage_virtualize ansible collection version 0.1.0 with same changes (no changes at all)
  • and then we plan release version 1.0.0 with changes in documentation plus extra features

Option 2:

  • ibm.storage_virtualize ansible collection version 1.0.0 with documentation changes plus extra features

@webknjaz
Copy link
Member

webknjaz commented May 9, 2023

@Shilpi-J I'd go for the option 2. Also, you could preserve the original Git history by using the original repo as the base, just pushing it to the new location and adding new commits on top. I'd cut a release right after making the commits that update the metadata (version, name etc.) and the docs + maybe an explanation block at the top of the readme. After this, the new collection would be usable and you could proceed with setting up redirects from the old one..

I'd be eager to hear from @felixfontein, though, since they're more involved with the community than I am. So my concerns may not match the community expectations in full.

@felixfontein
Copy link
Contributor

@Shilpi-J I think both is fine. For 1) I would include the docs changes already in 0.1.0 though. But from the community point of view it doesn't really matter, as long as you guarantee that the final release (1.0.0) is backwards compatible for things that worked with the old collection.

@Shilpi-J
Copy link
Author

Thanks @felixfontein @webknjaz We will proceed with option 2) mentioned above and will have v1.0.0 as first release.

@Shilpi-J
Copy link
Author

@felixfontein We got one request/question internally to have this new collection storage virtualize version as 2.0.1 as the deprecated spectrum virtualize version would be 2.0.0. We want to have new collection release version as 2.0.1 to avoid any confusion with the users.
I hope that should also be fine.
Thanks

@felixfontein
Copy link
Contributor

@Shilpi-J you can also do a 2.0.1 bugfix release with no changes, but you cannot use 2.0.1 as an initial release. Use 2.0.0 for that if you prefer 2.x.y.

@Shilpi-J
Copy link
Author

Thanks @felixfontein for the response.Let me get back to my team and share the inputs, will confirm you which version we are going ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants