Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGES import on Windows service provides failing results #801

Closed
RobPasMue opened this issue Oct 7, 2023 · 4 comments
Closed

IGES import on Windows service provides failing results #801

RobPasMue opened this issue Oct 7, 2023 · 4 comments
Assignees
Labels
bug Something isn't working PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side

Comments

@RobPasMue
Copy link
Member

See TODO in test_design_import.py::test_open_file - latest DMS version has started to fail here. Requires service investigation. Assigning to @jonahrb.

@RobPasMue RobPasMue added bug Something isn't working PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side labels Oct 7, 2023
@RobPasMue
Copy link
Member Author

Read lines

# TODO: Something has gone wrong with IGES
# TODO: Issue https://github.com/ansys/pyansys-geometry/issues/801
#
# file = tmp_path_factory.mktemp("test_design_import") / "two_cars.igs"
# design.download(file, DesignFileFormat.IGES)
# design2 = modeler.open_file(file)
# _checker_method(design, design2, False)

@jonahrb
Copy link
Contributor

jonahrb commented Oct 9, 2023

This is a known issue of additional empty components that occurs in SC product as well. Likely a stride bug, it has been reported. So this IGES test won't pass as-is until that is fixed. Other option as a possible workaround is to explicitly ignore empty components, but that's probably not ideal? @b-matteo @kmental , feel free to add any additional comments

@b-matteo
Copy link
Contributor

b-matteo commented Oct 9, 2023

This is a known issue of additional empty components that occurs in SC product as well. Likely a stride bug, it has been reported. So this IGES test won't pass as-is until that is fixed. Other option as a possible workaround is to explicitly ignore empty components, but that's probably not ideal? @b-matteo @kmental , feel free to add any additional comments

Thanks for the heads up @jonahrb . Personnally i think it's more consistent to keep the test the way it is and wait for a fix. If the fix is to be too delayed, we could make a specific test for IGES.

@RobPasMue RobPasMue linked a pull request Apr 12, 2024 that will close this issue
9 tasks
@RobPasMue
Copy link
Member Author

Closing in favor of #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side
Projects
None yet
Development

No branches or pull requests

3 participants