Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time column sorted as string when “Show expert columns" selected #655

Closed
Thracky opened this issue Aug 18, 2023 · 0 comments
Closed

Time column sorted as string when “Show expert columns" selected #655

Thracky opened this issue Aug 18, 2023 · 0 comments
Labels
Milestone

Comments

@Thracky
Copy link

Thracky commented Aug 18, 2023

Time values are sorted alphabetically in the expert columns view of the profiler.

I’m guessing that this is due to SimpleProfilerTableDataModel returning a float:
return decisionInfo.timeInPrediction/(1000.0 * 1000.0);)

versus ExpertProfilerTableDataModel returning a formatted string:
return milliUpToMicroFormatter.format(decisionInfo.timeInPrediction / (1000.0 * 1000.0));

@bjansen bjansen added the bug label Sep 13, 2023
@bjansen bjansen closed this as completed in 7e0c8e2 Oct 5, 2023
@bjansen bjansen added this to the 1.22 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants