Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 单元格 默认点击展示tooltips行为异常 / 框选功能 / 右键/选择单元格 #852

Closed
WeiShengv99 opened this issue Dec 1, 2021 · 7 comments · Fixed by #862
Assignees
Labels
🐛 bug 这个是一个 bug released

Comments

@WeiShengv99
Copy link

🏷 Version

Package Version
@antv/s2 - 1.1.2
@antv/s2-react - 1.1.1

🖋 Description

  1. 单元格的默认点击行为 会触发 tooltips 的展示, 再点击该单元格的时候, tooltips 有时会隐藏,有时会隐藏后再展示,行为不一致。
  2. 单元格框选功能在边缘情况下 会有框选异常
  3. 异常操作失焦等。。会导致tooltips 不再展示,刷新后恢复
  4. 自定义 tooltips key 问题

⌨️ Code Snapshots

2021-12-01.8.09.49.mov
2021-12-01.8.14.15.mov
2021-12-01.8.14.55.mov

🔗 Reproduce Link

https://antv-s2.gitee.io/zh/examples/react-component/switcher#pivot-with-children

🤔 Steps to Reproduce

问题: 框选问题

  1. 点击单元格 展示tootips
  2. 右键单元格 展示右键菜单
  3. 点击任何地方 让 右键菜单失焦 错误进入框选模式。

问题: 意外操作失焦

  1. mac 的comand + shift + 5 进入录屏模式 就会导致tootips 不展示

问题: tooltips 的行为不一致

  1. 重复点击单元格就可以试出来

问题: react key 报错
使用来源

this.spreadsheet.tooltip.show({
        position: { x: event.clientX, y: event.clientY },
        content: (
          <div
            className={Style.row_cell}
            key={`${item?.id}${item?.description}`}
          >
            <div>{item?.dimensionName}</div>
            <div>{item?.description}</div>
          </div>
        ),
      });

image

这里是复现的 demo
大概原因是因为 自定义组件里有2个 子元素 就会有key 问题

😊 Expected Behavior

  1. 不进入框选模式
  2. tooltips 行为一致,没有迷惑性
  3. 没有报错

😅 Current Behavior

可见上面的视频

💻 System information

chrome: v96.0.4664.55 macos Big Sur 11.6 (arm64)

@lijinke666 lijinke666 added the 🐛 bug 这个是一个 bug label Dec 1, 2021
@lijinke666 lijinke666 self-assigned this Dec 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

你好 @WeiShengv99,很抱歉给你带来了不好的体验, 我们会尽快排查问题并修复, 请关注后续发布日志.

Hello, @WeiShengv99, We are very sorry for the bad experience. We will troubleshoot and fix the problem as soon as possible. Please pay attention to the subsequent change logs.

@lijinke666
Copy link
Member

lijinke666 commented Dec 3, 2021

单元格框选功能在边缘情况下 会有框选异常

@WeiShengv99 这种情况有复现步骤吗?

@WeiShengv99
Copy link
Author

WeiShengv99 commented Dec 3, 2021

@WeiShengv99 这种情况有复现步骤吗?

@lijinke666 这个问题描述对应着 Steps to Reproduce里的 问题1 和 问题2,还有一些非常边缘的case 比较难以复现。现在不清楚是因为什么原因导致的,出现的场景大概率和分屏有关,我能稳定复现再提issue吧

@lijinke666
Copy link
Member

好的, 这三个问题已经修复, 非常感谢你的细致反馈
image

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

🎉 This issue has been resolved in version @antv/s2-v1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

🎉 This issue has been resolved in version @antv/s2-react-v1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

@WeiShengv99 欢迎使用 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug 这个是一个 bug released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants