Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hikari datasource connection-test-query become useless #2154

Closed
wy-coder opened this issue Apr 3, 2019 · 2 comments
Closed

hikari datasource connection-test-query become useless #2154

wy-coder opened this issue Apr 3, 2019 · 2 comments
Assignees

Comments

@wy-coder
Copy link

wy-coder commented Apr 3, 2019

Question

ShardingSphere-SQL - Logic SQL: /* ping */ SELECT 1

hikari datasource connection-test-query become useless , becouse of UnicastRoutingEngine.

@KomachiSion
Copy link
Member

@wy-coder, The SQL SELECT 1 should not be from hikariCP but from your application, such as spring-boot-actuator, detail see #2344 .
The hikari datasource connection-test-query will not print SQL Log by ShardingSphere-SQL.

Information you provided is not enough to reproduce this problem, so can you provide more information such as harding-sphere versions, sharding configurations and so on.
If you can provide a example code in GitHub will be better

@KomachiSion
Copy link
Member

The process of execute sql is
Application --> ShardingDataSource(parse, route) --> printSQL if sql.show = true --> Hikari connection pool.

So the SQLconnection-test-query set should not be print by ShardingSphere.
the reason why your log print ShardingSphere-SQL - Logic SQL: /* ping */ SELECT 1 may be something in your application invoke ShardingSphere to execute check/test SQL, such as spring-boot-actuator(detail see #2344 ).

So I think it's not a problem for ShardingSphere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants