-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] GENERIC_CHART_AXES: numeric x-axis treated as categorical values #26034
Comments
@villebro @zhaoyongjie Could you take a look at this one? |
I will take a look, thanks for reporting @rumbin |
Hey @villebro I checked the backend response and it's identical in this respect. I fed the json from Superset 2.0.1 backend into Superset 3.0.2rc1 frontend and it also misinterprets XAxis type. This made me convinced it's a FE issue. It looks like the getAxisTime defaults to AxisType.category in this case whereas it should return AxisType.time. |
I was able to repro, investigating now |
@villebro, we found a fix on our side. @WojtekWaga will report here tomorrow and/or provide a PR. |
@rumbin @WojtekWaga oops, I already opened a fix 🙁 Do you mind reviewing the PR #26087 to see if it's in line with the changes you were proposing? |
Thank you all! |
When using a numeric column as the generic x-axis, the x-axis values aren't linearly distributed along the x-axis but they are evenly distributed, just as if they were categorical values
How to reproduce the bug
GENERIC_CHART_AXES
feature flag enabledx
as x-axis and, e.g.,max(y)
as y-axisExpected results
This is what it should look like and what it did correctly in Superset 2.0.1:
Actual results
X-axis values are seemingly treated as categorical values:
Any distribution/scatter/histogram plots based on this functionality are actually unusable due to this bug.
Environment
(please complete the following information):
python --version
node -v
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: