Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grubs sometimes not resolving #395

Closed
cs716 opened this issue Jun 7, 2024 · 4 comments
Closed

Grubs sometimes not resolving #395

cs716 opened this issue Jun 7, 2024 · 4 comments
Assignees
Labels
bug Something is not working as intended

Comments

@cs716
Copy link
Member

cs716 commented Jun 7, 2024

  • Grubs will sometimes fail to resolve causing the game to lock up
  • This frequently happens when Hits/explosions under grubs velocity limit #394 occurs and a grub is launched. Grub potentially not resolving due to continued movement while flying away?

We could potentially put a band-aid on this by forcing grubs that do not resolve after a reasonable period to suicide.

@cs716 cs716 added the bug Something is not working as intended label Jun 7, 2024
@cs716
Copy link
Member Author

cs716 commented Jun 7, 2024

Some unstuck changes may have fixed this. I haven't been able to repro in my testing. Will monitor on PT Friday

@cs716 cs716 self-assigned this Jun 7, 2024
@DrewBritt
Copy link
Member

I believe I fixed the (a?) problem leading to the game freezing; if a Grub was damaged after the turn ended (landmine detonating another landmine is how I reliably repro'd), they'd try to call UseTurn again, which led to the gamemode locking. I've simply told the call to skip if the turn is already changing. I've also added a failsafe for Grubs not resolving, as it was the only await GameTask.Delay() call in a while loop that had the potential to run forever.

6b7dcbf

@trundlr
Copy link
Member

trundlr commented Jul 8, 2024

The band-aid is nice, although we need to handle the case of a Grub being unable to resolve when another object (grub, crate, landmine) is on top of its head.

@trundlr
Copy link
Member

trundlr commented Aug 31, 2024

Haven't seen this in awhile, but will keep an eye out!

@trundlr trundlr closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants