Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class based source readers? #119

Open
afaulconbridge opened this issue Dec 9, 2020 · 1 comment
Open

Class based source readers? #119

afaulconbridge opened this issue Dec 9, 2020 · 1 comment

Comments

@afaulconbridge
Copy link
Contributor

Currently, there is a single general Reader class with various methods for different sources.

I wonder if a series of specific classes for different filetypes be better e.g. Reader23andMe, ReaderAncestry, etc. Still keeping the single Reader class overall, but delegating a lot of the details to the specific classes for implementation.

By grouping everything for a particular format together it makes it easier to read, and to add extra sources. Also it would allow subclasses (e.g. for Global Screening Array based sources) to abstract functionality more easily.

@apriha
Copy link
Owner

apriha commented Dec 14, 2020

Thanks @afaulconbridge, this is a great idea. Since several read functions use the same parser, I wonder if the top level Reader class should implement the parser functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants