-
-
Notifications
You must be signed in to change notification settings - Fork 373
/
.golangci.yml
185 lines (176 loc) · 4.78 KB
/
.golangci.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
run:
timeout: 10m
go: "1.22"
tests: true
linters:
# Disable all linters.
disable-all: true
# Enable specific linter
enable:
# Nice to have
#- depguard
#- errcheck
#- gocritic
#- thelper
- errorlint
- dupword
- exportloopref
- forbidigo
- gofmt
- goimports
- gosec
- gosimple
- govet
- ineffassign
- misspell
- revive
- staticcheck
- tenv
- typecheck
- unconvert
# We must disable this one because there is no support 'optional' protobuf fields yet: https://github.com/arduino/arduino-cli/pull/2570
#- protogetter
linters-settings:
govet:
# Enable analyzers by name.
# Run `GL_DEBUG=govet golangci-lint run --enable=govet` to see default, all available analyzers, and enabled analyzers.
enable:
- appends
- asmdecl
- assign
- atomic
- atomicalign
- bools
- buildtag
- cgocall
- composites
- copylocks
- deepequalerrors
- defers
- directive
- errorsas
#- fieldalignment
- findcall
- framepointer
- httpresponse
- ifaceassert
- loopclosure
- lostcancel
- nilfunc
- nilness
- printf
- reflectvaluecompare
#- shadow
- shift
- sigchanyzer
- slog
- sortslice
- stdmethods
- stringintconv
- structtag
- testinggoroutine
- tests
- unmarshal
- unreachable
- unsafeptr
- unusedresult
- unusedwrite
forbidigo:
forbid:
- p: ^(fmt\.Print(|f|ln)|print|println)$
msg: in cli package use `feedback.*` instead
- p: (os\.(Stdout|Stderr|Stdin))(# )?
msg: in cli package use `feedback.*` instead
analyze-types: true
revive:
confidence: 0.8
rules:
#- name: error-return
#- name: unused-parameter
#- name: var-naming
- name: blank-imports
- name: context-as-argument
- name: context-keys-type
- name: dot-imports
- name: empty-block
- name: error-naming
- name: error-strings
- name: errorf
- name: exported
- name: increment-decrement
#- name: indent-error-flow
- name: package-comments
- name: range
- name: receiver-naming
- name: redefines-builtin-id
- name: superfluous-else
- name: time-naming
- name: unreachable-code
- name: var-declaration
- name: defer
- name: atomic
- name: waitgroup-by-value
errorlint:
# Check for plain error comparisons.
comparison: true
# We might evalute to allow the asserts and errofs in the future
# Do not check for plain type assertions and type switches.
asserts: false
# Do not check whether fmt.Errorf uses the %w verb for formatting errors.
errorf: false
issues:
# Fix found issues (if it's supported by the linter).
fix: false
# List of regexps of issue texts to exclude.
#
# But independently of this option we use default exclude patterns,
# it can be disabled by `exclude-use-default: false`.
# To list all excluded by default patterns execute `golangci-lint run --help`
#
# Default: https://golangci-lint.run/usage/false-positives/#default-exclusions
exclude-rules:
# Exclude some linters from running on tests files.
- path: _test\.go
linters: [gosec, errcheck]
# G401: Use of weak cryptographic primitive
- linters: [gosec]
text: "G401"
# G501: Blocklisted import crypto/md5: weak cryptographic primitive
- linters: [gosec]
text: "G501"
# G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server
- linters: [gosec]
path: internal/integrationtest/
text: "G112"
# G204: Subprocess launched with a potential tainted input or cmd arguments
- linters: [gosec]
path: executils/process.go
text: "G204"
# SA1019: req.GetQuery is deprecated: Marked as deprecated in cc/arduino/cli/commands/v1/lib.proto.
- linters: [staticcheck]
path: commands/lib/search.go
text: "SA1019"
# Ignore revive emptyblock
- linters: [revive]
path: arduino/libraries/loader.go
text: "empty-block"
- linters: [revive]
path: arduino/serialutils/serialutils.go
text: "empty-block"
- linters: [revive]
path: arduino/resources/download.go
text: "empty-block"
- linters: [revive]
path: arduino/builder/internal/progress/progress_test.go
text: "empty-block"
- linters: [revive]
path: internal/algorithms/channels.go
text: "empty-block"
# Run linters only on specific path
- path-except: internal/cli/
linters:
- forbidigo
- path: internal/cli/.*_test.go
linters: [forbidigo]
- path: internal/cli/feedback/
linters: [forbidigo]