Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arichornlover and uYouEnhanced #1

Open
bhackel opened this issue Jun 26, 2024 · 85 comments
Open

arichornlover and uYouEnhanced #1

bhackel opened this issue Jun 26, 2024 · 85 comments

Comments

@bhackel
Copy link

bhackel commented Jun 26, 2024

Hello, did something bad happen to your account? Hope you are okay

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jun 26, 2024

Hello, did something bad happen to your account? Hope you are okay

I can simply explain this, I think it was that profile picture on the arichornlover account not being as appropriate so I pretty much changed it right after I’ve seen the email of GitHub flagging it and the rule I broke.
the account will come back soon hopefully but can’t confirm which time or day it will come though.

also the good thing is I can still commit changes in uYouEnhanced even if the repo is hidden so I can try to resolve those compiling errors

also here’s my AltSources from uYouEnhanced below.

Download (AltSources)

@bhackel
Copy link
Author

bhackel commented Jun 26, 2024

Ah that is not too bad. Hopefully your account is restored soon. I did see those commits come through on my fork, which was quite strange.

@arichornloverALT
Copy link
Owner

Ah that is not too bad. Hopefully your account is restored soon. I did see those commits come through on my fork, which was quite strange.

That was me trying to fix the compiling errors in the buildapp.yml, compiling broke whenever I got flagged.

@bhackel
Copy link
Author

bhackel commented Jun 26, 2024

That makes sense with all of the forks on your account being down as well then

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jun 26, 2024

I just now updated them to be using the arichornloverALT forks
so compiling should be fixed I think?

by the way, I can’t manually trigger actions due to the flagging so can’t confirm if it solves it.

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jun 27, 2024

Hey bhackel, can you test this implementation works as intended? I was working on it in main-nightly and making it a replacement to the uYou option calledFullscreen always to the right since it doesn’t do anything.

I tested this on an iPad (with iPhone Layout on) and could not tell the difference if it did anything or not.

Fullscreen to the right Implementation
// Disable Pull to Full for landscape videos - @bhackel
@interface YTWatchPullToFullController : NSObject
@property(nonatomic, strong) YTWatchViewController *playerViewSource;
@end
@interface YTWatchViewController (uYouEnhanced)
@property(nonatomic, strong) YTWatchPullToFullController *pullToFullController;
- (NSUInteger) allowedFullScreenOrientations;
// Fullscreen to the Right (uYouEnhanced/YTLitePlus Version) - @arichornlover
- (BOOL) fullscreen;
- (UIInterfaceOrientationMask) supportedInterfaceOrientations;
- (UIInterfaceOrientation) preferredInterfaceOrientationForPresentation;
- (void)forceRightFullscreenOrientation; // custom property
@end

// Fullscreen to the Right (iPhone-exclusive) - @arichornlover
// NOTE: Disable the “Portrait Fullscreen” Option while the code below is active.
%group gFullscreenToTheRight
%hook YTWatchViewController
- (UIInterfaceOrientation)preferredInterfaceOrientationForPresentation {
    if ([self fullscreen] && UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone) {
        return UIInterfaceOrientationLandscapeRight;
    }
    return %orig;
}
- (UIInterfaceOrientationMask)supportedInterfaceOrientations {
    if ([self fullscreen] && UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone) {
        return UIInterfaceOrientationMaskLandscape;
    }
    return %orig;
}
%new
- (void)forceRightFullscreenOrientation { // custom void
    if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone) {
        NSNumber *value = [NSNumber numberWithInt:UIInterfaceOrientationLandscapeRight];
        [[UIDevice currentDevice] setValue:value forKey:@"orientation"];
    }
}
%end
%end

and if it works as intended then I will push this into uYouEnhanced!

@bhackel
Copy link
Author

bhackel commented Jun 27, 2024

Ok I can try it now

@bhackel
Copy link
Author

bhackel commented Jun 27, 2024

Getting this crash at the moment:

  "exception" : {"codes":"0x0000000000000000, 0x0000000000000000","rawCodes":[0,0],"type":"EXC_CRASH","signal":"SIGABRT"},
  "termination" : {"flags":0,"code":6,"namespace":"SIGNAL","indicator":"Abort trap: 6","byProc":"YouTube","byPid":2936},
  "asi" : {"libsystem_c.dylib":["abort() called"]},
  "exceptionReason" : {"arguments":["%s","fullscreen","0x130cf1200"],"format_string":"-[%s %s]: unrecognized selector sent to instance %p","name":"NSInvalidArgumentException","type":"objc-exception","composed_message":"-[%s fullscreen]: unrecognized selector sent to instance 0x130cf1200","class":"NSException"},

I am tired right now, but I think you should check that the attribute fullscreen exists on the class.

@arichornloverALT
Copy link
Owner

Getting this crash at the moment:

  "exception" : {"codes":"0x0000000000000000, 0x0000000000000000","rawCodes":[0,0],"type":"EXC_CRASH","signal":"SIGABRT"},
  "termination" : {"flags":0,"code":6,"namespace":"SIGNAL","indicator":"Abort trap: 6","byProc":"YouTube","byPid":2936},
  "asi" : {"libsystem_c.dylib":["abort() called"]},
  "exceptionReason" : {"arguments":["%s","fullscreen","0x130cf1200"],"format_string":"-[%s %s]: unrecognized selector sent to instance %p","name":"NSInvalidArgumentException","type":"objc-exception","composed_message":"-[%s fullscreen]: unrecognized selector sent to instance 0x130cf1200","class":"NSException"},

I am tired right now, but I think you should check that the attribute fullscreen exists on the class.

Thanks for letting me know, I will change that.

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jun 28, 2024

Also I’ve went onto Reddit and a lot of Sideloaded/jailbreak members think I’m banned due to a dmca, I wish I could tell them I wasn’t banned and it wasn’t because of a dmca 😅

@bhackel
Copy link
Author

bhackel commented Jun 28, 2024

Yeah lots of people thinking that without checking much - I guess it’s the most logical thing though.

@KarmaBeast
Copy link

I hope they restore you asap! I was literally scared and upset when I noticed the repo was gone 🥶

@KarmaBeast
Copy link

@arichornloverALT Any news on when the repo will be restored?

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jul 1, 2024

@arichornloverALT Any news on when the repo will be restored?

Well, not really, I contacted GitHub Support on June 26th and haven’t gotten a response yet. So I have no clue on when it’ll return.

but I would like to say I ported almost every repo to this alt

@dnet890
Copy link

dnet890 commented Jul 1, 2024

@arichornloverALT I got flagged before by Github support and usually it takes weeks to respond. just be patient

@arichornloverALT
Copy link
Owner

@arichornloverALT I got flagged before by Github support and usually it takes weeks to respond. just be patient

I know, but GitHub support happens at any time, it could be weeks or even months

@Smelly-Ghost
Copy link

Dang that really sucks. I’ve been checking a bunch the last few days cause I want to update my current build. Hope you can get the account back soon or migrate to this one.

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jul 2, 2024

Dang that really sucks. I’ve been checking a bunch the last few days cause I want to update my current build. Hope you can get the account back soon or migrate to this one.

You can. Just merge to the latest changes and than go to actions and Update Submodules and after that you can build it! 😁

@KarmaBeast
Copy link

KarmaBeast commented Jul 2, 2024

Let's hope it'll be restored very soon. uYouEnhanced needs to continue. We need multiple app choices not fewer. This situation will only make Google happy.

  • We all contributed a lot to the repo with our posts, requests, ideas and now that the repo is hidden, all those posts, comments are unavailable...

It's super frustrating and upsetting, so let's hope we'll be restored soon.

Repository owner deleted a comment from andrew1-1 Jul 2, 2024
@IceBotYT
Copy link

IceBotYT commented Jul 3, 2024

Built with latest YouTube version, now icons are missing. Any workarounds?

@Smelly-Ghost
Copy link

Dang that really sucks. I’ve been checking a bunch the last few days cause I want to update my current build. Hope you can get the account back soon or migrate to this one.

You can. Just merge to the latest changes and than go to actions and Update Submodules and after that you can build it! 😁

Oh awesome thanks. I was able to get it to build with the new submodules. Though it seems there’s an issue with the recent version of YouTube as various UI elements are missing lol so I rolled back to 19.22.6

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jul 3, 2024

Built with latest YouTube version, now icons are missing. Any workarounds?

you can downgrade to 19.23.3 which was the last version before the problem ever happened.

and if you don’t want to downgrade then I’ll remove the IAmYouTube code .

@IceBotYT
Copy link

IceBotYT commented Jul 3, 2024

you can downgrade to 19.23.3 which was the last version before the problem ever happened.

Did that and it started crashing on launch, so I rolled it back (forward?) to 19.25.4

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jul 4, 2024

I found this interesting A/B flag on YouTube mainAppCoreClientEnableModernIaFrostedTopBar
when enabled it activates the UlBlurEffectStyleDark (Dark Theme) or UlBlurEffectStyleExtraLight (Light Theme) effect on the Navigation Bar!
IMG_1919

There is more flags like this but unfortunately uYou might’ve broken them so this is the only one that will work.

@bhackel
Copy link
Author

bhackel commented Jul 5, 2024

Ah I did see that my tab bar (at the bottom for Home/Subscriptions/etc) had this translucent effect for a bit. They must be implementing a bunch of this type of change

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jul 5, 2024

Ah I did see that my tab bar (at the bottom for Home/Subscriptions/etc) had this translucent effect for a bit. They must be implementing a bunch of this type of change

I think these are the A/B flags that give you the translucent effect in the tab bar. So they are indeed implementing it, but it’s also a cool UI implementation!
mainAppCoreClientEnableModernIaFrostedBottomBar
mainAppCoreClientEnableModernIaFrostedPivotBar
mainAppCoreClientEnableModernIaFrostedPivotBarUpdatedBackdrop
mainAppCoreClientEnableModernIaOpacityPivotBar

@Smelly-Ghost
Copy link

Dang that really sucks. I’ve been checking a bunch the last few days cause I want to update my current build. Hope you can get the account back soon or migrate to this one.

You can. Just merge to the latest changes and than go to actions and Update Submodules and after that you can build it! 😁

Oh awesome thanks. I was able to get it to build with the new submodules. Though it seems there’s an issue with the recent version of YouTube as various UI elements are missing lol so I rolled back to 19.22.6

Apparently I got tagged on another issue (qnblackcat/uYouPlus#1508) that this issue is fixed on YTLitePlus. Is that a fix that could be implemented in uYouEnhance or should I just migrate my YouTube IPA to YTLitePlus? I see @bhackel has a repo for that one and commented on the issue. So maybe for the time being that would be worth doing ?

@bhackel
Copy link
Author

bhackel commented Jul 9, 2024

YTLitePlus is a completely separate project, so some people find that it is missing some features from uYou. However, the developer of the base tweak YTLite, who is Dayanch96, is actively developing the tweak and fixing bugs. I recommend trying YTLitePlus, and seeing if it has the things you want, and if not, then switching back to uYouPlus/uYouEnhanced

@Smelly-Ghost
Copy link

Appreciate it thanks

@arichornloverALT
Copy link
Owner

I’ve already did that nearly a month ago, can you check the username in the sdks and make sure it’s either Theos or arichornloverALT?

@KieranBLK
Copy link

I’ve already did that nearly a month ago, can you check the username in the sdks and make sure it’s either Theos or arichornloverALT?

Ah. I got it. Just had to update the username. Thx! 🤗

@yodaluca23
Copy link

It's been over a month, they still haven't reinstated your account? Have they given any updates? Have you tried reaching out?

@arichornloverALT
Copy link
Owner

It's been over a month, they still haven't reinstated your account? Have they given any updates? Have you tried reaching out?

I did reach out, it might take longer then a month I am guessing.

@yodaluca23
Copy link

Also, I just realized you updated it to work, even with your account suspended, and updated mine, to the latest commit, the latest YouTube version, and great news, Notifications are back! There was a bug that prevented them for a long time, and two, the missing icons/images have been fixed! I've been using YouTube without icons for the past month 😭

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jul 27, 2024

Also, I just realized you updated it to work

You didn’t know I could still update uYouEnhanced? The good thing is I was still able to maintain it even if I’m suspended.

the missing icons/images have been fixed! and great news, Notifications are back!

I removed PoomSmart’s Sign in fix code, that probably was the reason 😅

@yodaluca23
Copy link

yodaluca23 commented Jul 27, 2024

You didn’t know I could still update uYouEnhanced? The good thing is I was still able to maintain it even if I’m suspended.

I knew you could still update it. I had been seeing commits coming in, but I knew the build script didn't worked without all the links to your account working but I just saw the notice in the ReadME today explaining how to get it to work.

I removed PoomSmart’s Sign in fix code, that probably was the reason 😅

Ah, maybe you could make it togglable, or only active if the user is signed out?

@arichornloverALT
Copy link
Owner

arichornloverALT commented Jul 27, 2024

Ah, maybe you could make it togglable, or only active if the user is signed out?

I like the idea but how would I be able to do that? (I’m talking about the “only active if user is signed out” to prevent confusion)
Would be hard to do don’t you think?
I think the toggleable option is a good idea since it is simple.

@yodaluca23
Copy link

I like the idea but how would I be able to do that? (I’m talking about the “only active if user is signed out” to prevent confusion) Would be hard to do don’t you think? I think the toggleable option is a good idea since it is simple.

Probably would be complex yes, I know on the web you can see if the user is logged in with yt.config_.LOGGED_IN true being they are false being they are not, there may be something similar on the app? then making it active or not should be easy?

@yodaluca23
Copy link

@arichornloverALT I see in the commits it says you added the sign-in fix back, but the icons are still working, I also couldn't find a toggle for it. Did you get it to work else how? or is it only working when signed out?

@arichornloverALT
Copy link
Owner

@arichornloverALT I see in the commits it says you added the sign-in fix back, but the icons are still working, I also couldn't find a toggle for it. Did you get it to work else how? or is it only working when signed out?

I didn’t make the option yet, give me a moment, I’ll be including the toggle!

@yodaluca23
Copy link

@arichornloverALT I see in the commits it says you added the sign-in fix back, but the icons are still working, I also couldn't find a toggle for it. Did you get it to work else how? or is it only working when signed out?

I didn’t make the option yet, give me a moment, I’ll be including the toggle!

Yep, I see it now, toggling it on, does cause icons to not load...

@KarmaBeast
Copy link

KarmaBeast commented Aug 13, 2024

https://www.reddit.com/r/github/s/vB3kTqpI9q

This davorg guy seems like GitHub employee. Arichorn try comment your case on there (!)

Nevermind. He's not with GitHub 😔
It's been 2 months (!!!)

@arichornloverALT
Copy link
Owner

arichornloverALT commented Aug 13, 2024

It’s fine, at this point this is my main account now. 😅

@KarmaBeast
Copy link

No cannot accept such loss. All our posts, comments, bug reports in the repo inaccessible. We wait as long as it takes for GitHub support to restore it 😣🫡

@Invisible40
Copy link

I followed this thread a while ago but am not up-to-date. So arichornlover's main account is still suspended. Is uYouEnhanced still being updated/maintained?

@arichornloverALT
Copy link
Owner

I followed this thread a while ago but am not up-to-date. So arichornlover's main account is still suspended. Is uYouEnhanced still being updated/maintained?

I updated it a week ago, so it should work on the latest release of YouTube.

@Invisible40
Copy link

I followed this thread a while ago but am not up-to-date. So arichornlover's main account is still suspended. Is uYouEnhanced still being updated/maintained?

I updated it a week ago, so it should work on the latest release of YouTube.

Ohhh I just saw that there is a uYouEnhanced on this account, thank you

@arichornloverALT
Copy link
Owner

arichornloverALT commented Aug 15, 2024

I followed this thread a while ago but am not up-to-date. So arichornlover's main account is still suspended. Is uYouEnhanced still being updated/maintained?

I updated it a week ago, so it should work on the latest release of YouTube.

Ohhh I just saw that there is a uYouEnhanced on this account, thank you

That’s not what I meant. I meant I updated the @arichornlover uYouEnhanced a week ago. I probably won’t the @arichornloverALT version.

@Invisible40
Copy link

I followed this thread a while ago but am not up-to-date. So arichornlover's main account is still suspended. Is uYouEnhanced still being updated/maintained?

I updated it a week ago, so it should work on the latest release of YouTube.

Ohhh I just saw that there is a uYouEnhanced on this account, thank you

That’s not what I meant. I meant I updated the @arichornlover uYouEnhanced a week ago. I probably won’t the @arichornloverALT version.

How are you able to update the uYouEnhanced on your @arichornlover account if it is still suspended? Also, to check, are the releases on the @arichornloverALT version accurate?

@arichornloverALT
Copy link
Owner

I followed this thread a while ago but am not up-to-date. So arichornlover's main account is still suspended. Is uYouEnhanced still being updated/maintained?

I updated it a week ago, so it should work on the latest release of YouTube.

Ohhh I just saw that there is a uYouEnhanced on this account, thank you

That’s not what I meant. I meant I updated the @arichornlover uYouEnhanced a week ago. I probably won’t the @arichornloverALT version.

How are you able to update the uYouEnhanced on your @arichornlover account if it is still suspended? Also, to check, are the releases on the @arichornloverALT version accurate?

Not accurate, the arichornloverALT version contains code that isn’t stable, so I recommend not using that version.

and I have no clue on why I still have the ability to update the @arichornlover version but the good thing is that it works. (except GitHub actions)

@Invisible40
Copy link

Ok thanks!!

@Invisible40
Copy link

I will stay on my current version (uYouEnhanced 19.20.02-3.0.3) and wait for your main account to be activated again before installing any new uYouEnhanced versions

@Strealstud
Copy link

Beybman hows it going? I'm sorry you got banned or smth I don't know what happened but I love the app you have made just wanted to check in bye

@Jazooxd
Copy link

Jazooxd commented Aug 26, 2024

Hello i try build uYouEnhanced but it fails with this error:

Error: Process completed with exit code 2.

"Fix Compiling (and) Build Package"

/Users/runner/work/uYouEnhanced/uYouEnhanced/main/.theos/obj/arm64/uYouEnhanced.dylib] Error 2
make[1]: *** [/Users/runner/work/uYouEnhanced/uYouEnhanced/theos/makefiles/instance/library.mk:37: internal-library-all_] Error 2
make: *** [/Users/runner/work/uYouEnhanced/uYouEnhanced/theos/makefiles/master/rules.mk:146: uYouEnhanced.all.tweak.variables] Error 2
Error: Process completed with exit code 2.

@arichornloverALT
Copy link
Owner

arichornloverALT commented Sep 2, 2024

Sorry about that, I was updating something in uYouEnhanced and I unfortunately couldn’t test to see if it worked since @arichornlover is still suspended. which also disables the ability to run actions. But overall it should work fine now hopefully.

@arichornloverALT
Copy link
Owner

arichornloverALT commented Sep 2, 2024

Beybman hows it going? I'm sorry you got banned or smth I don't know what happened but I love the app you have made just wanted to check in bye

I didn’t really “made” the tweak.
This would not have been possible without MiRO92, qnblackcat, bhackel, dayanch96 & anyone else I may have forgotten to credit.

but imo YTLitePlus has newer stuff that uYouEnhanced is lacking.

@yodaluca23
Copy link

but imo YTLitePlus has newer stuff that uYouEnhanced is lacking.

Where can I get that, I didn't fork it before your account was banned 😭

@arichornloverALT
Copy link
Owner

arichornloverALT commented Sep 2, 2024

but imo YTLitePlus has newer stuff that uYouEnhanced is lacking.

Where can I get that, I didn't fork it before your account was banned 😭

https://github.com/ytliteplus/ytliteplus
The last time I viewed this was nearly a month ago and I’m shocked with how it’s looking. balackburn and bhackel has done a great job with contributing!

@arichornloverALT
Copy link
Owner

arichornloverALT commented Sep 2, 2024

Honestly, 25 minutes later and I’ve been thinking. Maybe YTLitePlus isn’t a good idea after seeing this issue. You could still choose it but the prompt could be annoying so it’s up to you. Not to disrespect the developers behind YTLite(YouTubePlus) & YTLitePlus. YTLitePlus/YTLitePlus#395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

13 participants