-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 compatibility issue with Java 8 #702
Comments
@aalmiray When you did the release, did you use JDK8? |
I could reproduce that the module is set to the JDK used, at least with Luckily, simply adding the toolchain to
Btw, another thing, I initially got an error running asciidoctor-gradle-plugin/gradle/publishing.gradle Lines 117 to 121 in d59ca0d
|
Can you PR that toolchain change, please? |
The description change removes the description, I need to look into it more carefully. There's a dot being added at some point |
Yes, it is coming from somewhere else. I thought it best to get the update plugin suit out, rather than worry about fixing it at that point in time. We should anyway rather refactor that pomXml code to be done in |
Thanks for the quick merge.
Not a problem 👍 But then, should we get 4.0.1 asap out and create a separated issue to discuss the "description" ? |
Yes. |
No, I used JDK11 as that's my default these days. Sorry, I'll use JDK8 for the patch release. |
I am unable to bump form 3.3.2 to 4.0.0
More data:
asciidoctor-gradle-jvm-4.0.0.module
from local/caches
actually mentions java"org.gradle.jvm.version": 11,
. Code seems fine: CI; sourceCompatibility... is using Java8, but maybe the module picked up the version used during the release?The text was updated successfully, but these errors were encountered: