Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer the width and height from the generated image #387

Open
ggrossetie opened this issue Aug 31, 2022 · 1 comment
Open

Infer the width and height from the generated image #387

ggrossetie opened this issue Aug 31, 2022 · 1 comment
Labels
💡 proposal 🍩 enhancement New feature or request

Comments

@ggrossetie
Copy link
Member

It would nice to infer the width and height from the generated image when width and height are not explicitly defined.
For reference, Asciidoctor Diagram does the following:

PNG
https://github.com/asciidoctor/asciidoctor-diagram/blob/66876e9c11c401eec943ff6968cd0c5f6c443906/lib/asciidoctor-diagram/util/png.rb#L9-L22

GIF
https://github.com/asciidoctor/asciidoctor-diagram/blob/66876e9c11c401eec943ff6968cd0c5f6c443906/lib/asciidoctor-diagram/util/gif.rb#L10-L18

SVG
https://github.com/asciidoctor/asciidoctor-diagram/blob/66876e9c11c401eec943ff6968cd0c5f6c443906/lib/asciidoctor-diagram/util/svg.rb#L7-L24

Originally posted by @Mogztter in #99 (comment)

@ggrossetie ggrossetie added 💡 proposal 🍩 enhancement New feature or request labels Aug 31, 2022
@nekator
Copy link

nekator commented May 3, 2023

Encountered this difference between asciidoctor-kroki and asciidoctor-diagram today as i replaced asciidoctor-diagram with asciidoctor-kroki. Missing width and height resulted in failing tests.
confluence-publisher/confluence-publisher@6500369#diff-46f69509d7d0c7f3b137dc0c21c7c8a787aba4a30ba7c527efa63173f1a9e8bcR1273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 proposal 🍩 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants