Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon not changing to theme update #157

Open
jrozner opened this issue May 2, 2022 · 3 comments
Open

Icon not changing to theme update #157

jrozner opened this issue May 2, 2022 · 3 comments
Labels
bug Something isn't working triage Issue needs triage

Comments

@jrozner
Copy link
Member

jrozner commented May 2, 2022

OS version (uname -a if on a Unix-like system. For windows run winver and copy the text starting "Version "): Windows and Linux

QT version if dynamically linking (qtdiag |head -n 3): Qt 6.3.0

Description of the problem including expected versus actual behavior: When changing from light to dark mode or vice versa the icon in the tray bar will not update. The code to support this has been implemented in #138 but there is an upstream bug in Qt causing it not to work. The issues is tracked https://bugreports.qt.io/browse/QTBUG-103093. We need to wait for either Qt to fix the bug or provide a new solution to implement this.

Steps to reproduce:

  1. Start ashirt
  2. Switch from light to dark or dark to light
@jrozner jrozner added bug Something isn't working triage Issue needs triage labels May 2, 2022
@jrozner
Copy link
Member Author

jrozner commented Nov 2, 2022

According to the ticket the upstream issue has been fixed in Qt 6.4.0 by adding new functionality to support this. In testing #208 I checked whether this behavior was fixed and it doesn't appear to be. I'm going to go ahead and upgrade us to 6.4.0 to get the support for this but we should have ICS look at the implementation done before and determine if something is wrong.

@jrozner
Copy link
Member Author

jrozner commented Mar 22, 2023

It looks like the implementation to support this might only be supported on KDE. The code to support this should exist within the application, so long as the event is getting emitted, but unclear as to whether or not Qt will ever emit the event.

@jrozner
Copy link
Member Author

jrozner commented Apr 20, 2023

More activity on the ticket. Look like there is confirmation that the patches did not work and the ticket maybe re-opened. 6.5 is supposed to independently introduce some changes that may help but the event specifically is not currently being triggered. Again, the code is already written to support this so when the code lands that supports this, it should "just work".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant