Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client submits tags that have been deleted from the evidence creation modal #229

Open
audibleblink opened this issue Jul 18, 2023 · 2 comments
Labels
bug Something isn't working triage Issue needs triage

Comments

@audibleblink
Copy link

audibleblink commented Jul 18, 2023

OS version

Linux box 6.3.0-1-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.3.7-1 (2023-06-12) x86_64 GNU/Linux

QT version if dynamically linking (qtdiag |head -n 3):
n/a

Description of the problem including expected versus actual behavior:
Client (v1.2.0) submits tags that have been deleted from the ashirt modal

Steps to reproduce:

  1. Create any kind of evidence with tag: test and submit it.
  2. Begin new evidence creation; note that test is auto-populated
  3. Delete the test tag and continue to submit the evidence
  4. Note in the web interface the test tag exists on the evidence created in step 3, despite it being deleted from the client prior to submission.

Provide logs (if relevant):

@audibleblink audibleblink added bug Something isn't working triage Issue needs triage labels Jul 18, 2023
@audibleblink
Copy link
Author

this is also throws an error if a user switches operations and attempts to submit evidence with a non-existent (in that operation) tag.

  • user in op_1 operation
  • user creates op_1_tag
  • user switches operations in client
  • user deletes op_1_tag from modal
  • submit evidence to op_2

image

@audibleblink
Copy link
Author

Was asked to test on latest client and server. This issue remains.

An additional point:

  • Despite removing the tag on step 3 from the UI modal, the removed tag still appears in the offline Accumulated Evidence list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

1 participant