Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black 24.1.1 Conflict #367

Closed
cooncesean opened this issue Jan 29, 2024 · 1 comment
Closed

Black 24.1.1 Conflict #367

cooncesean opened this issue Jan 29, 2024 · 1 comment

Comments

@cooncesean
Copy link

cooncesean commented Jan 29, 2024

Issue Description

Our team just upgraded major versions from black==23.1.0 to black==24.1.1 (https://github.com/psf/black/releases/tag/24.1.1) which was just released two days ago. This introduces a conflict with reorder-python-imports (which we also use) around the introduction of new blank lines after a module-level docstring. black wants to introduce a new line between the docstring and the first line of code. reorder-python-imports wants that line to be removed.

It appears that that is the lone issue. Video of this in action.

Steps To Reproduce

  1. Upgrade your local version of black to their most recent release.
  2. Modify a file with a module level docstring.
  3. Run the black command locally.
  4. Run the reorder-python-imports command locally.
  5. See the conflict.

Thanks for the assist and this fantastic tool; LMK if there is anything else I can do to help.

@asottile
Copy link
Owner

search the issue tracker next time

Repository owner locked as off-topic and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants