Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for coroutines #39

Open
dabitdev opened this issue Nov 29, 2020 · 2 comments
Open

Add support for coroutines #39

dabitdev opened this issue Nov 29, 2020 · 2 comments

Comments

@dabitdev
Copy link
Collaborator

The current CashImpl implementation of Cash SDK uses listeners to return the values.
It should be interesting to support co-routines instead of listeners.
For example:

fun login(network: BtcNetwork, phoneNumber: String, listener: Cash.WacCallback) 

With co-routine

 suspend fun login(network: BtcNetwork, phoneNumber: String): Result<WacCallback>
@herou
Copy link

herou commented Nov 30, 2020

@dabitdev Please, check this PR #40

@herou
Copy link

herou commented Dec 1, 2020

@dabitdev You can assign to me other tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants