Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in ext.js Format module #45

Open
dnet opened this issue Mar 29, 2018 · 2 comments
Open

False positive in ext.js Format module #45

dnet opened this issue Mar 29, 2018 · 2 comments

Comments

@dnet
Copy link

dnet commented Mar 29, 2018

Source: https://github.com/pjreddie/WRed/blob/3b446e19643b1e298933b622ba72929f362713f2/media/JavaScript/ext-3.2.1/src/util/Format.js#L296

throw ('NumberFormatException: invalid format, formats should have no more than 1 period: ' + format);

The above line matches the regex ([A-Za-z\.]+)Exception: which results in a false positive.

@augustd
Copy link
Owner

augustd commented Mar 30, 2018

This is an example ASP.Net error message we are trying to match against:

System.Web.Services.Protocols.SoapException: Web Exception ---> System.Exception:

It will be difficult to rule out this false positive without also creating a false negative as well.

@dnet
Copy link
Author

dnet commented Jun 29, 2018

I think you fixed this in e72368d (#49). If you agree, you can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants