Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Enable html-attribute in tooltip #228

Closed
JoschaMetze opened this issue Aug 10, 2016 · 3 comments
Closed

Feature request: Enable html-attribute in tooltip #228

JoschaMetze opened this issue Aug 10, 2016 · 3 comments

Comments

@JoschaMetze
Copy link

Hi Daniel,

I would love to see the html option in the tooltip component:

html Allow custom html inside the tooltip. (Default: false)
Materialize page for tooltip

Any chance on adding this? Otherwise I would consider a pull request implementing this.

Thanks
Joscha

@Thanood
Copy link
Collaborator

Thanood commented Aug 10, 2016

Should be easy enough, I guess. Just a new @bindable and a change to the tooltip call..
I can add this.

If you'd like to make a PR anyway, feel free to do so. 😄
In that case, please adjust your commit messages to follow our commit message conventions.
Would be something like "feat(md-tooltip): add html switch".

I can merge and release in a few hours from now, when I get home.

Btw.: I've read their release notes but somehow missed that you could put html in tooltips now, thanks!

@JoschaMetze
Copy link
Author

Having problems right now to correctly build aurelia-materialize-bridge (jspm over mobile on a train doesn't really work...). So no pull request today. If you don't have time to add this till the end of the week I'll create the pull request on Friday.

@Thanood
Copy link
Collaborator

Thanood commented Aug 10, 2016

Just added the change. Thanks again. 😄
Edit: also uploaded http://aurelia-ui-toolkits.github.io/demo-materialize/#/samples/dialogs/tooltip-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants