-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
md-label with <md-input md-type="time"> should have the active class set up #310
Comments
This is on chrome... but still have the |
Thanks for the report, perfect timing. I will have to do some modifications anyway. 😄 I'm not sure though. |
Reproduced it here: I wonder if Materialize itself has support for time inputs and if so, where we failed to transfer this. 😃 |
The real problem with this issue is that Materialize doesn't update |
Added static "active" to label when it's a time input. |
I find out that if I use that kind of input :
<md-input md-type="time" md-label="startTime" md-value.bind="Start Time"></md-input>
The
Start Time
label is on the same line as the--:--
empty value or even on a entered value like12:15
. I see that to put aactive
class on the label could be more appropriate with this kind of input because it always display something in the input.I have take a look at the code of the
input/input.js
and I have added this 3 lines in theattached()
, which make the trick :I don't know if you think it a good idea?
The text was updated successfully, but these errors were encountered: