Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ink bar in the md-tabs are not updating based on the selection #315

Closed
manumqln opened this issue Nov 10, 2016 · 9 comments
Closed

Ink bar in the md-tabs are not updating based on the selection #315

manumqln opened this issue Nov 10, 2016 · 9 comments

Comments

@manumqln
Copy link

manumqln commented Nov 10, 2016

The ink bar under the tabs are not moving to the corresponding tabs based on the tab selection unlike the original materializecss tabs.

@Thanood
Copy link
Collaborator

Thanood commented Nov 10, 2016

Thanks for the report. Still doing the necessary changes for 0.97.8 ( #307 ).
Tabs are next. 😃

@Thanood Thanood added the bug label Nov 10, 2016
@manumqln
Copy link
Author

No worries.
Thanks :)

@Thanood
Copy link
Collaborator

Thanood commented Nov 10, 2016

All I know atm is their calcLeftPos() always return 0.. Not sure why.

@Thanood
Copy link
Collaborator

Thanood commented Nov 10, 2016

I don't believe this.. It's when you use Waves on tabs! 😂
The original Materialize doesn't use this anywhere..

Waves make the container position: relative; and because of that the position of the child (a in the tab li) cannot be calculated correctly, it's always at left: 0.

Let's see if I can fix that or if we'll have to prevent waves in tabs.
(not sure if that's "material" at all but I like it)

@Thanood
Copy link
Collaborator

Thanood commented Nov 10, 2016

On a side note (to myself): The active tab is not responding to theme color change.

@Thanood
Copy link
Collaborator

Thanood commented Nov 10, 2016

Reopened because this isn't fixed in IE11..

@Thanood Thanood reopened this Nov 10, 2016
@manumqln
Copy link
Author

Wow! Thanks 👍

@Thanood
Copy link
Collaborator

Thanood commented Nov 10, 2016

It was a lunchbreak project for today.. 😉

@Thanood
Copy link
Collaborator

Thanood commented Dec 13, 2016

Reopening because this definitely needs documentation. 😃
☝️ 13. Dezember 2016 10:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants