Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename case-consistency rule #141

Open
atsu85 opened this issue Dec 2, 2016 · 1 comment
Open

Filename case-consistency rule #141

atsu85 opened this issue Dec 2, 2016 · 1 comment

Comments

@atsu85
Copy link
Contributor

atsu85 commented Dec 2, 2016

@dagtveit stumbled upon issue related to having two instances of the same module that was intended to be singleton:

I am trying to share a service class across nested custom elements. but the service class dosnt have the same values.

He found out that it was caused by inconsistent letter-cases

it was due to that i wrote small d in documentData in one of the imports and big D in the other one. laaaaaaaaalllalalalal hhehehehe

It reminded me, that I had made the same mistake once, and it took me also a bit time to figure out the problem.
It would be nice, if the linter would detect this issue as well.

@MeirionHughes
Copy link
Contributor

May be better to issue an warning if the case of the file name is not exactly the same as what was requested. For one, that in itself could be a problem on linux installations set up to be case sensitive.

Either way, its easier to check for this in the reworked code.

@MeirionHughes MeirionHughes changed the title Check that imports use the same letter-case as module name (derived from file name) Filename case-consistency rule Dec 3, 2016
@MeirionHughes MeirionHughes self-assigned this Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants