Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rancher2-deployment: DRY_RUN must not connect Rancher #87

Open
bemeyert opened this issue Feb 13, 2020 · 0 comments
Open

rancher2-deployment: DRY_RUN must not connect Rancher #87

bemeyert opened this issue Feb 13, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bemeyert
Copy link
Contributor

With the commits 3cc4667c4aa8e93261a96f3262931fe4c8825ed and 4c351d4 DRY_RUN became more or less useless. The new code contacts a Rancher-cluster even if DRY_RUN is set. DRY_RUN is also for local testing and development. This would then only work if there is a working internet connection and Rancher credentials are setup.

To give DRY_RUN it's intended purpose back the connection to Rancher should not be done when DRY_RUN is set.

@bemeyert bemeyert added the bug Something isn't working label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant