-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-ecs: AsgCapacityProvider
depends on AutoScalingGroup
#29174
aws-ecs: AsgCapacityProvider
depends on AutoScalingGroup
#29174
Comments
As a hack (since I know that
But actually adding the
Results in the same error but now for
More and more it seems like this construct should just not allow |
Thanks for the report. Yes I can reproduce this and I agree with your suggestion. |
Giving some visibility into this issue, here are the options that I have been considering/testing at the AsgCapacityProvider's level:
The latest option seems to be the right solution. But regarding the other comment in this issue:
Make me think that we should probably go with the option 1 or a mix of the option 2 and apply the same logic in the IMO, the main point that needs to be clarified is how much useful would that be to let a user provide an imported ASG to an |
@cheruvian could you give us more details about the reason why you would like to bring an ASG defined outside of the CDK application? Like I mentioned, this seems to add a lot of constraints (painful configuration that you would have to manage yourself) which would remove most of the benefit of using the L2 constructs. |
|
1 similar comment
|
Describe the bug
AsgCapacityProviderProps
declaresautoscalingGroup
to be anIAutoScalingGroup
but then coerces to anAutoScalingGroup
.Expected Behavior
Properly handles
IAutoScalingGroup
or does not allowIAutoScalingGroup
to be passed in.Current Behavior
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.126.0
Framework Version
No response
Node.js Version
v20.10.0
OS
OSX
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: