Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYO Kinesis Stream to aws-kinesisstreams-lambda #58

Closed
2 tasks done
dscpinheiro opened this issue Sep 10, 2020 · 1 comment
Closed
2 tasks done

BYO Kinesis Stream to aws-kinesisstreams-lambda #58

dscpinheiro opened this issue Sep 10, 2020 · 1 comment
Assignees
@dscpinheiro
Labels
enhancement New feature or request

Comments

@dscpinheiro
Copy link
Contributor

Similar to how an existingLambdaObj? can be supplied for select patterns to bring-your-own Lambda function, I'm seeking the ability to bring-your-own Kinesis Stream to this pattern.

Use Case

This feature would be useful if the user already has a data stream table in their account that they would like to retroactively connect to a Lambda function.

Proposed Solution

Add an existingStreamObj? pattern prop, similar to aws-apigateway-kinesisstreams.

Question: Would it also make sense to update the eventSourceProps property to be of type KinesisEventSourceProps (instead of EventSourceMappingOptions)? The other patterns for Lambda (such as aws-dynamodb-stream-lambda and aws-s3-lambda) are already using the types from aws-lambda-event-sources.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@dscpinheiro dscpinheiro added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Sep 10, 2020
@hnishar hnishar added enhancement New feature or request and removed needs-triage The issue or PR still needs to be triaged feature-request A feature should be added or improved labels Sep 10, 2020
@dscpinheiro dscpinheiro mentioned this issue Sep 11, 2020
Merged
@hnishar
Copy link
Contributor

hnishar commented Sep 14, 2020

The update has been pushed out in v1.63.0

@hnishar hnishar closed this as completed Sep 14, 2020
@i906 i906 mentioned this issue Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dscpinheiro dscpinheiro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dscpinheiro @hnishar