curious about the CWAlerm threshold for kinesis.

[watany-dev]

aws-solutions-constructs/source/patterns/@aws-solutions-constructs/core/lib/kinesis-streams-helper.ts

Line 66 in 5124e47

threshold: 2592000, // 12 Hours (50% of 24 hours - default record retention period)

Question about this place.
The threshold is 2592000, but isn't what this number represents 30 days to the second? I didn't understand it when I actually made it.
I believe the 12 hours in the comment refers to 43,200 seconds!

Reproduction Steps

cdk deploy

Error Log

no.

Environment

• CDK CLI Version :2.20
• CDK Framework Version:2.20
• AWS Solutions Constructs Version :2.05
• OS :Amazonlinux2
• Language :Typescript

---

This is 🐛 Bug Report

[biffgaut]

This certainly looks like an error. We'll discuss it as a team and look at addressing it. Thanks.

[biffgaut]

Fixed in PR #667, will be released in 1.153.0 and 2.6.0

[Benjscho]

Asking for clarity here, isn't the metric in Milliseconds, not seconds? (GetRecords.IteratorAgeMilliseconds)

Not sure how the original threshold number was arrived at, but as it stands it seems like the threshold should be increased by 10^3

[biffgaut]

It sure looks like you are correct - we'll look a little closer and update accordingly unless other info comes to light. Thanks.