-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with RDS #322
Comments
Bump! Any plans to support this? |
@srikanthnutigattu-tomo yes, still planned for 3.0, but the design work still pending. Is there something specific you are looking for in this integration or you would like to share ideas? |
Specifically looking for support of Read replicas on AWS Postgres Aurora RDS. Currently all queries go to read/write, which no helping autoscaling of RDS. |
Understood. Yes it is planned. For the time being, you can follow Vlad's tutorial: https://vladmihalcea.com/read-write-read-only-transaction-routing-spring/ |
Excited for this! |
Are there any plans to provide support for rotating credentials with spring cloud aws RDS ? |
@mandarbk I only planned for supporting rotating credentials with RDS + Secrets Manager. I am missing knowledge about ACM Managed Crtificates. |
Hi I am assuming I feel this enhancement request should be backed in to 3.x.x if not already. Steps to recreate:
In 2.x.x the library is attempting to "createInstance" and calls describe-db-instances which results below: (using cli to replicate the issue) Class: AmazonRdsReadReplicaAwareDataSourceFactoryBean
From result:
|
For handling clusters - can we add a flag Replace |
@virajkanwade we do not plan anymore to include JDBC module in 3.0 version. It MAY be included again in the future, but we prefer to wait for AWS to stabilize work on their JDBC drivers that partially cover what Spring Cloud AWS 2.x offered. |
so whats the solution for people who want to leverage the auto failover of Aurora RDS? Implement and maintain the convoluted work around available? When there could just be a small patch in the current version? |
AWS has implemented/is implementing failover capabilities on the driver level:
|
@maciejwalkowiak any recommendation on this ? |
The recommendation is to use one of the solutions linked above as we are not adding JDBC module to 3.0 yet. |
@maciejwalkowiak I am not sure if you read my summary, this is not entirely related to Fail over management which can be acheived by your suggestion. The above issue is with leveraging read replicas for an RDS that are cross regional(like we do using |
Oh apologies, I missed that I did not add 3rd link there. Follow this approach for read & write replica. https://vladmihalcea.com/read-write-read-only-transaction-routing-spring/ Vlad explained approach that we internally do in Spring Cloud AWS 2.x |
For anyone interested in keeping it simple and wishing to use the spring-cloud-aws-jdbc: virajkanwade/spring-attic-spring-cloud-aws@d0ed817 Also a compiled jar available. https://github.com/virajkanwade/spring-attic-spring-cloud-aws/releases/tag/v2.2.7.RELEASE You can use local maven repo for using the jar. NOTE: The vladmihalcea approach is good. But it uses a custom JPA configuration file https://github.com/vladmihalcea/high-performance-java-persistence/blob/c75c3df14daf043d4014307e07efac4b5129739c/core/src/test/java/com/vladmihalcea/book/hpjp/util/spring/config/jpa/AbstractJPAConfiguration.java. It seems to hardcode additionalProperties. We would need additional logic to parse spring application.properties to dynamically configure these options. |
Submitted PR in correct repo |
Regarding
Yes please! |
@roelmang you should be able to connect to RDS Proxy without Spring Cloud AWS? Perhaps you can explain what bits are problematic. |
I was at first looking into overriding some beans from the library to fetch the rds proxy details, but opted for not using the library at all for datasource configuration. |
@maciejwalkowiak - Are you planning to support IAM based auth for the RDS? I will be happy to support and implement if the work for 3.0 release has been started. |
@zeagord there is a project from AWS that covers IAM auth: https://github.com/awslabs/aws-advanced-jdbc-wrapper Or maybe you have something different in mind? |
Hi, any plans for r2dbc support? |
Hi @gnagy. No. Perhaps you can ask AWS folks if they have any plans: https://github.com/awslabs/aws-advanced-jdbc-wrapper |
native read-replica support with spring boot + rds proxy would be useful. |
Hi folks! Have you made any progress with this task? |
This issue collects all the requirements for RDS support in Spring Cloud AWS 3.0 (based on AWS SDK v2).
The key feature in RDS integration is support for read replicas:
readOnly
connections (transactions started with@Transactional(readOnly=true)
Additionally we need to support:
Both can be achieved with official drivers:
Regarding read replicas support, in addition to what has been offered in 2.x we must support:
To research:
The text was updated successfully, but these errors were encountered: