Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid self-referential struct patterns #202

Open
jonathanpwang opened this issue Oct 28, 2023 · 0 comments
Open

Avoid self-referential struct patterns #202

jonathanpwang opened this issue Oct 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jonathanpwang
Copy link
Contributor

jonathanpwang commented Oct 28, 2023 •
edited
Loading

It was a mistake to have FpChip contain RangeChip as a reference. This makes it near-impossible to create a struct that stores both FpChip and RangeChip at the same time (without using Rust crates like ouroboros or rental).

We should have either just had FpChip own RangeChip, or have it own Arc<RangeChip> (some minor performance impact).
@jonathanpwang jonathanpwang added the enhancement New feature or request label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanpwang and others