Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyConstraintManager should contain witness_gen_only #210

Open
jonathanpwang opened this issue Nov 2, 2023 · 2 comments
Open

CopyConstraintManager should contain witness_gen_only #210

jonathanpwang opened this issue Nov 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jonathanpwang
Copy link
Contributor

Since it is shared everywhere, it should have the source of truth so different structs don't need to individually hold their own trackers of witness_gen_only.
@jonathanpwang jonathanpwang added the enhancement New feature or request label Nov 2, 2023
@nyunyunyunyu
Copy link
Contributor

Should CircuitBuilder not have witness_gen_only?

@jonathanpwang
Copy link
Contributor Author

The problem is we often have different virtual region managers and they each need to know about witness_gen_only. I think we've been encountering a bunch of places where it's inconvenient to also pass it in or make sure CircuitBuilder is always accessible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nyunyunyunyu @jonathanpwang and others