Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withdrawal messages does not seem to show up #7

Closed
digizeph opened this issue Jul 8, 2022 · 2 comments
Closed

withdrawal messages does not seem to show up #7

digizeph opened this issue Jul 8, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@digizeph
Copy link
Member

digizeph commented Jul 8, 2022

When cross-checking messages showing from the cli, comparing against the ris-live web app, I cannot see any withdraw messages showing up on the tool.

We should also filter messages at the elem level so that when ris-live bundles multple announcements, we only display the ones user wanted.
@digizeph digizeph added the bug Something isn't working label Jul 8, 2022
@digizeph
Copy link
Member Author

digizeph commented Jul 8, 2022

The issue seems to be that the UPDATE struct does not contain withdrawal fields.

ris-live-rs/src/messages/ris_message.rs

Line 27 in a5f8ea4

announcements: Option<Vec<Announcement>>

It's possible that the withdrawal field was added recently.
image

@digizeph digizeph mentioned this issue Jul 9, 2022
Merged
@digizeph
Copy link
Member Author

digizeph commented Jul 9, 2022

Withdrawal message support added in #8.

@digizeph digizeph closed this as completed Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@digizeph