OptachUpgrade version check not working

[satheesanraja]

Hi Biemond,

I facing some issue like i have installed the New Optach using Optachupgarde class..When i want to run the puppet again. The Optachupgrade trying to upgrade once again.Which is causing some dependency and failing the other class. Could you please recommend to optach version check to work after i run puppet again
Info: Applying configuration version '1560345436'
Notice: orawls::opatchupgrade 28186730 /apps/oracle/product/fmw/middleware12c/OPatch/version.txt installed - performing upgrade
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Notify[orawls::opatchupgrade 28186730 /apps/oracle/product/fmw/middleware12c/OPatch/version.txt installed - performing upgrade]/message: defined 'message' as 'orawls::opatchupgrade 28186730 /apps/oracle/product/fmw/middleware12c/OPatch/version.txt installed - performing upgrade'
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[extract opatch upgrade 28186730 p28186730_139400_Generic.zip]/returns: executed successfully
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: Launcher log file is /tmp/OraInstall2019-06-12_01-17-40PM/launcher2019-06-12_01-17-40PM.log.
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: Extracting the installer . . . . Done
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: Checking if CPU speed is above 300 MHz. Actual 3491.914 MHz Passed
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: Checking swap space: must be greater than 512 MB. Actual 32765 MB Passed
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: Checking if this platform requires a 64-bit JVM. Actual 64 Passed (64-bit not required)
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: Checking temp space: must be greater than 300 MB. Actual 4983 MB Passed
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: Preparing to launch the Oracle Universal Installer from /tmp/OraInstall2019-06-12_01-17-40PM
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: All of feature sets selected for installation and their components have already been installed for the distribution OPatch 13.9.4.2.0 in the home directory /apps/oracle/product/fmw/middleware12c
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns:
Notice: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: The log(s) can be found here: /tmp/OraInstall2019-06-12_01-17-40PM.
Error: 'java -jar /tmp/install//wls_opatch/6880880/opatch_generic.jar -silent oracle_home=/apps/oracle/product/fmw/middleware12c' returned 1 instead of one of [0]
Error: /Stage[main]/Icon_wls_admin::Opatchupgrade/Orawls::Opatchupgrade[28186730]/Exec[install opatch upgrade 28186730]/returns: change from 'notrun' to ['0'] failed: 'java -jar /tmp/install//wls_opatch/6880880/opatch_generic.jar -silent oracle_home=/apps/oracle/product/fmw/middleware12c' returned 1 instead of one of [0]
Info: Orawls::Opatchupgrade[28186730]: Unscheduling all events on Orawls::Opatchupgrade[28186730]

[biemond]

so what is your manifest for this

I use this
'''
opatchupgrade_instances:
'28186730':
oracle_product_home_dir: *wls_middleware_home_dir
patch_id: 6880880
patch_file: "p28186730_139400_Generic.zip"
opversion: 13.9.4.0.0
'''

[satheesanraja]

i use this

opatchupgrade_instances:
'28186730':
oracle_product_home_dir: *wls_middleware_home_dir
jdk_home_dir: *java_home_dir
patch_id: 6880880
patch_file: "p28186730_139400_Generic.zip"
puppet_download_mnt_point: "/tmp/"
remote_file: false
download_dir: "/tmp/install/"
os_user: 'oracle'
os_group: 'oinstall'
opversion: '13.9.4.0.0'
logoutput: false

class icon_wls_admin::opatchupgrade{
$default_params = {}
$opatchupgrade_instances = hiera('opatchupgrade_instances', {})
create_resources('orawls::opatchupgrade',$opatchupgrade_instances, $default_params)

[biemond]

ok then the check if failing https://github.com/biemond/biemond-orawls/blob/puppet4/manifests/opatchupgrade.pp#L39

that can happen because of /etc/orainst or inventory is not the default. or the right facts are not set.

https://github.com/biemond/biemond-orawls/blob/puppet4/lib/facter/orawls.rb#L92
in case of debug you should see it in the beginning of the puppet run